Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸ§ͺ [Unit Test] tournamentController λ‹¨μœ„ ν…ŒμŠ€νŠΈ #522

Merged
merged 6 commits into from
Feb 5, 2024
Merged

πŸ§ͺ [Unit Test] tournamentController λ‹¨μœ„ ν…ŒμŠ€νŠΈ #522

merged 6 commits into from
Feb 5, 2024

Conversation

middlefitting
Copy link
Member

πŸ“Œ κ°œμš”

  • TournamentController λ‹¨μœ„ν…ŒμŠ€νŠΈλ₯Ό μž‘μ„±ν•©λ‹ˆλ‹€.

πŸ’» μž‘μ—…μ‚¬ν•­

  • TournamentController λ‹¨μœ„ν…ŒμŠ€νŠΈ μž‘μ„±
  • @pathvarible 검증 및 λ‹¨μœ„ν…ŒμŠ€νŠΈ 편의λ₯Ό μœ„ν•΄ μ»¨νŠΈλ‘€λŸ¬μ— Validated μΆ”κ°€

πŸ’‘Issue 번호

@middlefitting middlefitting self-assigned this Jan 21, 2024
@middlefitting middlefitting linked an issue Jan 21, 2024 that may be closed by this pull request
πŸ§ͺ [Test] TournamentController λ‹¨μœ„ ν…ŒμŠ€νŠΈ #439
Closed
1 task
@middlefitting middlefitting changed the title πŸ§ͺ [Unit Test] tournamentcontroller λ‹¨μœ„ ν…ŒμŠ€νŠΈ πŸ§ͺ [Unit Test] tournamentController λ‹¨μœ„ ν…ŒμŠ€νŠΈ Jan 21, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2024 •
edited
Loading

Codecov Report

Attention: 694 lines in your changes are missing coverage. Please review.

Comparison is base (3193717) 10.25% compared to head (6e64ea1) 70.10%.
Report is 9 commits behind head on dev.

Files Patch % Lines
...erver/domain/noti/service/sns/SlackbotService.java 7.04% 66 Missing ⚠️
...com/gg/server/domain/item/service/ItemService.java 12.28% 46 Missing and 4 partials ⚠️
...gg/server/admin/user/service/UserAdminService.java 44.57% 44 Missing and 2 partials ⚠️
...min/tournament/service/TournamentAdminService.java 81.48% 15 Missing and 15 partials ⚠️
...com/gg/server/domain/game/service/GameService.java 72.89% 14 Missing and 15 partials ⚠️
...erver/admin/season/service/SeasonAdminService.java 70.21% 10 Missing and 18 partials ⚠️
...gg/server/admin/game/service/GameAdminService.java 72.36% 11 Missing and 10 partials ⚠️
...ver/domain/megaphone/service/MegaphoneService.java 56.25% 16 Missing and 5 partials ⚠️
...ver/admin/user/controller/UserAdminController.java 51.35% 17 Missing and 1 partial ⚠️
.../gg/server/domain/match/utils/MatchCalculator.java 60.46% 10 Missing and 7 partials ⚠️
... and 81 more
Additional details and impacted files 
@@              Coverage Diff              @@
##                dev     #522       +/-   ##
=============================================
+ Coverage     10.25%   70.10%   +59.84%     
- Complexity       78      831      +753     
=============================================
  Files           255      255               
  Lines          3812     3974      +162     
  Branches        357      365        +8     
=============================================
+ Hits            391     2786     +2395     
+ Misses         3410      976     -2434     
- Partials         11      212      +201
Flag Coverage Ξ”
integrationTest 69.70% <70.22%> (?)
unitTest 14.77% <9.07%> (+4.51%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@middlefitting middlefitting added bug Something isn't working test labels Jan 21, 2024
Kimhan-nah
Kimhan-nah reviewed Jan 26, 2024
View reviewed changes
Copy link
Member

@Kimhan-nah Kimhan-nah left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

slice test annotation으둜 λ§Œλ“€μ—ˆλ˜ @WebMvcUnitTestλŠ” exclude filter μ»€μŠ€ν…€ λ•Œλ¬Έμ— μ‚¬μš©ν•˜μ§€ μ•Šμ€ κ±΄κ°€μš”?
μ»¨ν‹€λ‘œλŸ¬ κ³„μΈ΅μ˜ λ‹¨μœ„ ν…ŒμŠ€νŠΈλ₯Ό μž‘μ„±ν•˜λ €κ³  ν•˜λŠ”λ° λ™μΌν•˜κ²Œ μ§„ν–‰ν•΄μ•Όλ˜λŠ” 건지 μ•„λ‹ˆλ©΄ λ§Œλ“€μ–΄λ‘” μ–΄λ…Έν…Œμ΄μ…˜λ§Œ μ„ μ–Έν•˜λ©΄ λ˜λŠ” 건지 κΆκΈˆν•©λ‹ˆλ‹Ή
그리고 파일λͺ… "*ControllerMvcTest"둜 ν†΅μΌν•˜λ‚˜μš”?

@middlefitting
Copy link
Member Author

slice test annotation으둜 λ§Œλ“€μ—ˆλ˜ @WebMvcUnitTestλŠ” exclude filter μ»€μŠ€ν…€ λ•Œλ¬Έμ— μ‚¬μš©ν•˜μ§€ μ•Šμ€ κ±΄κ°€μš”? μ»¨ν‹€λ‘œλŸ¬ κ³„μΈ΅μ˜ λ‹¨μœ„ ν…ŒμŠ€νŠΈλ₯Ό μž‘μ„±ν•˜λ €κ³  ν•˜λŠ”λ° λ™μΌν•˜κ²Œ μ§„ν–‰ν•΄μ•Όλ˜λŠ” 건지 μ•„λ‹ˆλ©΄ λ§Œλ“€μ–΄λ‘” μ–΄λ…Έν…Œμ΄μ…˜λ§Œ μ„ μ–Έν•˜λ©΄ λ˜λŠ” 건지 κΆκΈˆν•©λ‹ˆλ‹Ή 그리고 파일λͺ… "*ControllerMvcTest"둜 ν†΅μΌν•˜λ‚˜μš”?

파일λͺ…은 ν†΅μΌν•˜λ©΄ 쒋을 것 같은데 νšŒμ˜λ•Œ 이야기해보면 쒋을 것 κ°™μŠ΅λ‹ˆλ‹€.

@Kimhan-nah Kimhan-nah marked this pull request as draft January 30, 2024 11:09
@middlefitting middlefitting force-pushed the 439-test-tournamentcontroller-λ‹¨μœ„-ν…ŒμŠ€νŠΈ branch from c90beff to 6e64ea1 Compare February 3, 2024 17:54
@middlefitting middlefitting mentioned this pull request Feb 3, 2024
Closed
3 tasks
@middlefitting middlefitting marked this pull request as ready for review February 3, 2024 17:58
SONGS4RI
SONGS4RI approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@SONGS4RI SONGS4RI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ν™•μΈν•˜μ˜€μŠ΅λ‹ˆλ‹€!

@Kimhan-nah Kimhan-nah merged commit 97e75ac into dev Feb 5, 2024
2 checks passed
@Kimhan-nah Kimhan-nah deleted the 439-test-tournamentcontroller-λ‹¨μœ„-ν…ŒμŠ€νŠΈ branch February 5, 2024 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kimhan-nah Kimhan-nah Kimhan-nah approved these changes

@SONGS4RI SONGS4RI SONGS4RI approved these changes

Assignees

@middlefitting middlefitting

Labels
bug Something isn't working test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

πŸ§ͺ [Test] TournamentController λ‹¨μœ„ ν…ŒμŠ€νŠΈ
4 participants
@middlefitting @codecov-commenter @Kimhan-nah @SONGS4RI